Don't block worker thread waiting for SQL transaction#3885
Closed
kim wants to merge 1 commit into
Closed
Conversation
Enough SQL requests piling up can exhaust the tokio worker pool waiting to acquire a transaction lock. Move `begin_mut_tx` to the blocking pool instead.
gefjon
reviewed
Dec 16, 2025
gefjon
left a comment
gefjon
left a comment
Contributor
There was a problem hiding this comment.
I don't think we should be using asyncify on the database cores, at least currently, as they aren't properly configured with blocking threads. Probably the way to fix this is just to actually configure the blocking threads, with a sensible number of them and with appropriate core pinning.
Contributor
|
I'm also confused by your PR description. This function runs on the database cores, so there should only be one Tokio worker, right? |
Contributor
Author
|
Ah right, I had actually discarded this after realizing it's not the main runtime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enough SQL requests piling up can exhaust the tokio worker pool waiting
to acquire a transaction lock. Move
begin_mut_txto the blocking poolinstead.
Expected complexity level and risk
1
Testing
Covered by existing tests.